fix(appbuilder): SAM local debugging: region and credential in launch config should override toolkit default #6011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Nov 13, 2024
packages/toolkit/.changes/next-release/Bug Fix-e5a76bd7-06a7-4a59-aead-8ea3e3924ee9.json
Outdated
Show resolved
Hide resolved
roger-zhangg
changed the title
roger-zhangg
changed the title
justinmk3
reviewed
Nov 14, 2024
packages/core/src/test/shared/sam/debugger/samDebugConfigProvider.test.ts
Outdated
Show resolved
Hide resolved
justinmk3
reviewed
Nov 14, 2024
packages/core/src/test/shared/sam/debugger/samDebugConfigProvider.test.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fix #5957
Appbuilder added
--regionparameter tosam local invoke, however this region is always reading region prop from default toolkit connection. Ignoring region set in sam debug config.Solution
region and credential set in sam debug config should override region and credential in current active toolkit connection.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.