Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README suggestion #1

Closed
alexbilbie opened this issue Aug 31, 2017 · 1 comment
Closed

README suggestion #1

alexbilbie opened this issue Aug 31, 2017 · 1 comment
Assignees
Milestone

Comments

@alexbilbie
Copy link

alexbilbie commented Aug 31, 2017

After some experimentation I've been able to successfully integrate this into my application, thank you!

After the "Configuration" section and before the "Capture" section in the README's Quick Start can I recommend adding a simple example of how to start a segment and subsegment for those developers who aren't working with HTTPS based services:

// Start a segment:
ctx, seg := xray.BeginSegment(context.Background(), "my-service-name")

ctx, subSeg := xray.BeginSubsegment(ctx, "Some unit of work")
// ...
// some unit of work here
// ...
subSeg.Close(nil)

// Close the segment
seg.Close(nil)
@alexbilbie alexbilbie changed the title README suggestions README suggestion Aug 31, 2017
dlsniper added a commit to dlsniper/aws-xray-sdk-go that referenced this issue Sep 4, 2017
dlsniper added a commit to dlsniper/aws-xray-sdk-go that referenced this issue Sep 4, 2017
@luluzhao luluzhao self-assigned this Sep 6, 2017
@luluzhao luluzhao added this to the code-review milestone Sep 6, 2017
@luluzhao
Copy link
Contributor

luluzhao commented Sep 8, 2017

@alexbilbie , we released a new version of SDK which contains your suggestions. Thank you for your suggestion.

@luluzhao luluzhao closed this as completed Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants