fix nilp error by #102 for tls conn (again) #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-yuki , thank you so much for the quick response. Let me try to run it again. |
|
@t-yuki , I merged your changes. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #105
Description of changes:
Fix nil pointer error again with a test fix due to timeout.
The test job https://travis-ci.org/aws/aws-xray-sdk-go/jobs/520674954 is failed for go1.9 env only.
However, if I set GOMAXPROCS=1 and run tests, it reproduces that test fail.
Maybe Recv timeout 100ms is too short for single goroutine env.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.