Bugfix #115
Merged
Bugfix #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2019 17:12
The err is otherwise in the scope of the returned error and a race with the spawned goroutine
None of the callbacks of ClientTrace can be assumed to not call in goroutines with other callbacks. We at least need to lock each of these functions. It is possible we could investigate further and reduce some of these locks once we clean up the segment locking order
|
A more in depth explanation of each bug is attached to the git commit message of each (they didn't get sent to the PR text on github above) |
|
@cep21 thanks for working on it. I merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address two bugs that are causing travis to fail