breaking: updates sampling.NewProxy to be private #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Makes
NewProxya private function by changing it tonewProxy.NewProxyis used by the centralized sampler to create an x-ray service client that uses the daemon as a proxy when callingGetSamplingRulesandGetSamplingTargets.Since this is a public method, it's possible that users could be calling this API and relying on the returned values from
GetSamplingRulesandGetSamplingTargets. Since these APIs return structs from the AWS SDK v1, we could break consumers of the API if we decide to update our centralized sampler to use the AWS SDK v2.I feel this method doesn't provide enough value to warrant exposing it publicly, given it ties us to continue using the V1 SDK. It's fairly straightforward to create an X-Ray service client that points to the daemon if that's required outside of the SDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.