fix: no longer error when checking .then on variables #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think properties are only unnaccesible on null and undefined, so as far as I know this should fully catch this case. Let me know if there's more things.
chrisradek
reviewed
Apr 22, 2019
chrisradek
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #114 (comment)
Description of changes:
Prevents errors from occurring on the case that a variable is null or undefined and being checked on whether it's a promise through accessing the .then property.
I think properties are only inaccessible on null and undefined, so as
far as I know this should fully catch this case. Let me know if there's
more.
Sorry for the double if you already fixed it, noticed #114 (comment) after I already made these changes so I thought I might as well open a PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.