Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MySQL timeout #248

Merged
merged 3 commits into from
Feb 9, 2020
Merged

Support MySQL timeout #248

merged 3 commits into from
Feb 9, 2020

Conversation

MMulaosmanovic
Copy link
Contributor

#244

use timeout if it is present

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@willarmiros
Copy link
Contributor

Hi @MMulaosmanovic,
Thank you for this PR, I'll take a look as soon as I can. For future reference it does not appear to need any change to the mysql_p.d.ts file since the timeout parameter is a field of MySQL.QueryOptions (reference).

Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with MySQL sample app. Approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants