Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lambda trace IDs #361

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Update Lambda trace IDs #361

merged 3 commits into from
Dec 28, 2020

Conversation

willarmiros
Copy link
Contributor

Description of changes:
Ensure that Lambda trace IDs will never be null, even outside the function handler. This extends #284. Also change the wording in the Lambda CME to clarify common cases that would cause the _X_AMZN_TRACE_ID to not be present, rather than simply stating it's not present.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@lupengamzn lupengamzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willarmiros willarmiros merged commit dd34e7e into aws:master Dec 28, 2020
@willarmiros willarmiros deleted the lambda-bug branch December 28, 2020 19:38
EkeMinusYou pushed a commit to EkeMinusYou/aws-xray-sdk-node that referenced this pull request Jan 28, 2021
* inital commit

* cleanups

* updated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants