Make it idempotent to capturePromise #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add uncapturePromise function in order to cancel patch in tests. fix aws#398
willarmiros
reviewed
Apr 7, 2021
| @@ -70,3 +70,6 @@ function sendRequest(address, cb) { | |||
| .on('error', cb) | |||
| .end(); | |||
| } | |||
|
|
|||
| // Cancel the patch because it doesn't affect other tests | |||
| require('../../lib/patchers/promise_p').uncapturePromise(); | |||
There was a problem hiding this comment.
So this is effectively cleanup for the integration test? If so, can we add it after the assertion so we're confident it's executed after the test will execute? Or perhaps wrap things in a try..finally block? Please inform me if I'm misunderstanding the purpose here.
There was a problem hiding this comment.
@willarmiros Thank you for your review. I moved cleanup for integration test after assertion, and change setup and cleanup process in promise_p.test.js too.
To ensure it's executed after the test will execute.
To assure variables reference to original `then` and `catch` function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#398
Description of changes:
Make it idempotent to capturePromise.
Add uncapturePromise function in order to cancel patch in tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.