updated non-dist paths #428
Conversation
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 36 36
Lines 1741 1741
=======================================
Hits 1440 1440
Misses 301 301 Continue to review full report at Codecov.
|
| @@ -5,8 +5,8 @@ var sinon = require('sinon'); | |||
| var sinonChai = require('sinon-chai'); | |||
|
|
|||
| var expressMW = require('../../lib/express_mw'); | |||
| var SegmentEmitter = require('../../../core/lib/segment_emitter.js'); | |||
| var ServiceConnector = require('../../../core/lib/middleware/sampling/service_connector.js'); | |||
| var SegmentEmitter = require('../../../core/dist/lib/segment_emitter.js'); | |||
There was a problem hiding this comment.
Is the dist repo going to be existed in the final assets that are packaged?
There was a problem hiding this comment.
Yep, the change in 3.3.2 was to repackage all of the content from lib into a dist directory, which is what's ultimately tested against and vended to customers.
There was a problem hiding this comment.
These unit tests were passing before because when you clone the source repo and build the SDK, you have access to BOTH the dist and lib directories. But once it is vended to customers, only the dist is available.
There was a problem hiding this comment.
Thanks for the clarification as I was thinking why unit tests didn't catch this
Issue #, if available:
#427
Description of changes:
Updated references to core package that used absolute path without
dist.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.