Update Subsegment Type Definitions to Include namespace
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to properly trace custom remote segments in XRay the namespace needs to be set to "remote". This allows TypeScript clients to correctly set the remote namespace on the SubSegment
mckalexee
changed the title
namespace
wangzlei
approved these changes
Oct 21, 2021
NathanielRN
approved these changes
Oct 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #470 +/- ##
=======================================
Coverage 82.48% 82.48%
=======================================
Files 36 36
Lines 1741 1741
=======================================
Hits 1436 1436
Misses 305 305 Continue to review full report at Codecov.
|
willarmiros
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#469
Description of changes:
Allow setting the namespace property on Subsegments.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.