fix: avoid fake .then() method on mysql2 Query class #501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #452
Description of changes:
The mysql2 package has a
Query
class with a.then()
method which throws an error when called.This confuses the current patching code, which sees this object as a
Promise
and calls.then()
on it.As a result, code like this currently breaks with an error:
This PR fixes this unfortunate interaction by performing an additional check to determine whether a returned value is actually a
Promise
.Beyond the new unit test (which fails without the change and passes with it), I can confirm this change has fixed the error in our application.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Fixes: #452