Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise empty exceptions array to fix unshift undefined error #508

Merged
merged 1 commit into from May 18, 2022
Merged

Initialise empty exceptions array to fix unshift undefined error #508

merged 1 commit into from May 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 13, 2022

Issue #, if available:

448

Description of changes:

Fixes unshift undefined error which can occur when two identical errors are sent consecutively.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Fixes unshift undefined error which can occur when two identical errors are sent consecutively. Issue described here #448
@ghost ghost self-requested a review as a code owner May 13, 2022 11:42
@codecov-commenter
Copy link

Codecov Report

Merging #508 (c465e93) into master (0124e92) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   82.50%   82.73%   +0.22%     
==========================================
  Files          36       36              
  Lines        1743     1743              
==========================================
+ Hits         1438     1442       +4     
+ Misses        305      301       -4     
Impacted Files Coverage Δ
lib/segments/attributes/subsegment.js 79.59% <0.00%> (+2.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0124e92...c465e93. Read the comment docs.

Copy link
Contributor

@carolabadeer carolabadeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@carolabadeer carolabadeer merged commit 16c96c5 into aws:master May 18, 2022
@ghost
Copy link
Author

ghost commented May 19, 2022

@carolabadeer thank you for the review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants