Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS declaration of TraceId to match definition #520

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

carolabadeer
Copy link
Contributor

Issue #, if available: Fixes issue #519

Description of changes: Updated constructor arguments in TypeScript TraceID class declaration to match the ones used in the class definition.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@carolabadeer carolabadeer requested a review from a team as a code owner July 21, 2022 22:45
Copy link
Contributor

@willarmiros willarmiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once linter is fixed :)

Copy link
Contributor

@atshaw43 atshaw43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider some negative tests for the input.

@carolabadeer carolabadeer merged commit bf0f26e into aws:master Jul 22, 2022
@carolabadeer carolabadeer deleted the fix-ts-traceid-declaration branch August 30, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants