Add workflow to deprecate SDK version #659
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #659 +/- ##
=======================================
Coverage 83.49% 83.49%
=======================================
Files 37 37
Lines 1806 1806
=======================================
Hits 1508 1508
Misses 298 298 ☔ View full report in Codecov by Sentry. |
|
|
||
| - name: Deprecate Version 3.7.0 | ||
| run: | | ||
| npm deprecate aws-xray-sdk@3.7.0 "3.7.0 is deprecated due to known issue in Lambda" |
There was a problem hiding this comment.
Is there an issue that we can link to in the deprecation message for further clarity?
There was a problem hiding this comment.
No public issue currently exists.
There was a problem hiding this comment.
Are these not why we are deprecating 3.7.0?
There was a problem hiding this comment.
We found the issue locally first, but you are right, these are the same issue.
Issue #, if available:
Description of changes:
Add workflow to specifically Deprecate v3.7.0 of the SDK. In the future, this workflow can be made more generic (add deprecation version and message as workflow input), but for now, 3.7.0 is specified.
Similar deprecation workflow: https://github.com/aws-observability/aws-rum-web/blob/main/.github/workflows/npm_deprecate.yaml
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.