Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current tox versions do not like how testenv.passenv is set #398

Closed
musicinmybrain opened this issue Aug 7, 2023 · 0 comments · Fixed by #399
Closed

Current tox versions do not like how testenv.passenv is set #398

musicinmybrain opened this issue Aug 7, 2023 · 0 comments · Fixed by #399

Comments

@musicinmybrain
Copy link
Contributor

Current tox versions do not seem to like how testenv.passenv is set in tox.ini. Using the system tox on Fedora Linux 38:

$ tox --version
4.4.12 from /usr/lib/python3.11/site-packages/tox/__init__.py
$ tox
py37-core: failed with pass_env values cannot contain whitespace, use comma to have multiple values in a single line, invalid values found 'TOXENV CI CODECOV_*'
[…]

There are more errors of that form for every tox environment, and everything fails fast.

If I make the recommended change from passenv = TOXENV CI CODECOV_* to passenv = TOXENV,CI,CODECOV_*, things work much better; I suspect the remaining failures are generally due to transient issues at httpbin.org.

PR to follow.
musicinmybrain added a commit to musicinmybrain/aws-xray-sdk-python that referenced this issue Aug 7, 2023
@musicinmybrain
Fix passing multiple values in testenv.passenv in tox.ini
1185bcf 
Current versions of tox advise: pass_env values cannot contain
whitespace, use comma to have multiple values in a single line

Fixes aws#398.
@musicinmybrain musicinmybrain mentioned this issue Aug 7, 2023
Merged
musicinmybrain added a commit to musicinmybrain/aws-xray-sdk-python that referenced this issue Oct 6, 2023
@musicinmybrain
Fix passing multiple values in testenv.passenv in tox.ini
2013ae5 
Current versions of tox advise: pass_env values cannot contain
whitespace, use comma to have multiple values in a single line

Fixes aws#398.
srprash added a commit that referenced this issue Oct 16, 2023
@musicinmybrain @srprash
Fix passing multiple values in testenv.passenv in tox.ini (#399)
9d27fe2 
Current versions of tox advise: pass_env values cannot contain
whitespace, use comma to have multiple values in a single line

Fixes #398.

Co-authored-by: Prashant Srivastava <50466688+srprash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix passing multiple values in testenv.passenv in tox.ini musicinmybrain/aws-xray-sdk-python
1 participant
@musicinmybrain