-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multi-stage build targets #1331
Comments
😄 Heya @jake-harris ! If this helps, you can modify the manifest before deploying to the "test" environment and the image should build properly before pushing to the ECR repository. |
Thanks for the response! Modifying the manifest with Ideally, in the manifest, there would be a
Which would output to:
|
Thanks yeah that totally makes sense, I've updated the issue with a feature request label for us to prioritize in our sprints! |
This PR allows to specify the `--target` and `--cache-from` docker build options with a [docker-compose](https://docs.docker.com/compose/compose-file/#cache_from) like syntaxe ```yaml image: build: dockerfile: path/to/dockerfile context: context/dir target: build-stage cache_from: - image:tag args: key: value ``` The `cache_from` option allows to pull a previously built image and use it as cache layers, and the `target` option allows... well, to use a multi-stages Dockerfile. Resolves #1331 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
This PR allows to specify the `--target` and `--cache-from` docker build options with a [docker-compose](https://docs.docker.com/compose/compose-file/#cache_from) like syntaxe ```yaml image: build: dockerfile: path/to/dockerfile context: context/dir target: build-stage cache_from: - image:tag args: key: value ``` The `cache_from` option allows to pull a previously built image and use it as cache layers, and the `target` option allows... well, to use a multi-stages Dockerfile. Resolves aws#1331 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
I may be going about this wrong, but I have a container which needs asset dependencies installed and compiled for a production build but not local/development builds. Specifically, I need to install npm dependencies and run gulp.
I couldn't think of a way to accomplish this, other than to create a multi-stage build in the Dockerfile and attempt to reference the specific stage but I don't see a way to do that with the init command.
If I have missed something or am attempting some grave sin by attempting this, I welcome any feedback.
Cheers!
The text was updated successfully, but these errors were encountered: