Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): update command logging verbiage to include jobs #1552

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

huanjani
Copy link
Contributor

Include jobs in command logging wording in env_init and app_init.

Addresses #1542

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Comment on lines -32 to -34
textPublicSubnets termprogress.Text = " - Public subnets for internet facing services "
textPrivateSubnets termprogress.Text = " - Private subnets for services that can't be reached from the internet"
textRouteTables termprogress.Text = " - Routing tables for services to talk with each other"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were the end-of-line extra spaces in textPublicSubnets and textECSCluster intentional? If so I can add them back in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope they weren't :) so it should be good!

@mergify mergify bot merged commit 2256074 into aws:mainline Oct 22, 2020
@huanjani huanjani deleted the command-logging branch October 22, 2020 19:56
thrau pushed a commit to localstack/copilot-cli-local that referenced this pull request Dec 9, 2022
Include `jobs` in command logging wording in `env_init` and `app_init`. 

Addresses aws#1542

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants