Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: decrypt secrets from SSM and secrets manager #5113

Merged
merged 23 commits into from
Jul 27, 2023
Merged

chore: decrypt secrets from SSM and secrets manager #5113

merged 23 commits into from
Jul 27, 2023

Conversation

Varun359
Copy link
Contributor

@Varun359 Varun359 commented Jul 21, 2023 •
edited
Loading

This is only for ECS services

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@Varun359 Varun359 requested a review from a team as a code owner July 21, 2023 17:11
@Varun359 Varun359 requested review from KollaAdithya and removed request for a team July 21, 2023 17:11
@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited
Loading

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51484 51400 +0.16
macOS (arm) 51680 51604 +0.15
linux (amd) 45316 45244 +0.16
linux (arm) 43588 43524 +0.15
windows (amd) 42136 42072 +0.15

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #5113 (edd6171) into mainline (5109d75) will decrease coverage by 0.08%.
Report is 1 commits behind head on mainline.
The diff coverage is 13.43%.

@@             Coverage Diff              @@
##           mainline    #5113      +/-   ##
============================================
- Coverage     69.65%   69.58%   -0.08%     
============================================
  Files           295      295              
  Lines         43243    43305      +62     
  Branches        285      285              
============================================
+ Hits          30122    30133      +11     
- Misses        11646    11697      +51     
  Partials       1475     1475
Files Changed Coverage Δ
internal/pkg/aws/secretsmanager/secretsmanager.go 67.60% <0.00%> (-8.59%) ⬇️
internal/pkg/aws/ssm/ssm.go 85.05% <0.00%> (-9.82%) ⬇️
internal/pkg/ecs/ecs.go 75.76% <0.00%> (-8.45%) ⬇️
internal/pkg/cli/local_run.go 51.35% <64.28%> (+9.81%) ⬆️

iamhopaul123
iamhopaul123 reviewed Jul 21, 2023
View reviewed changes
internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
internal/pkg/cli/local_run.go Outdated Show resolved Hide resolved
iamhopaul123
iamhopaul123 reviewed Jul 21, 2023
View reviewed changes
internal/pkg/aws/secretsmanager/secretsmanager.go Outdated Show resolved Hide resolved
internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
Lou1415926
Lou1415926 reviewed Jul 21, 2023
View reviewed changes
internal/pkg/aws/secretsmanager/secretsmanager.go Outdated Show resolved Hide resolved
internal/pkg/aws/ssm/ssm.go Outdated Show resolved Hide resolved
internal/pkg/cli/local_run.go Outdated Show resolved Hide resolved
internal/pkg/cli/local_run.go Show resolved Hide resolved
internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
dannyrandall
dannyrandall reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@dannyrandall dannyrandall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just some small nits and one question!

internal/pkg/aws/secretsmanager/secretsmanager.go Outdated Show resolved Hide resolved
internal/pkg/aws/ssm/ssm.go Outdated Show resolved Hide resolved
internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
internal/pkg/ecs/ecs.go Show resolved Hide resolved
internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
dannyrandall
dannyrandall approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@dannyrandall dannyrandall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 🚀

internal/pkg/ecs/ecs.go Outdated Show resolved Hide resolved
@dannyrandall dannyrandall added the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 25, 2023
@Varun359 Varun359 removed the do-not-merge Pull requests that mergify shouldn't merge until the requester allows it. label Jul 25, 2023
iamhopaul123
iamhopaul123 approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mergify mergify bot merged commit 0a886d6 into aws:mainline Jul 27, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lou1415926 Lou1415926 Lou1415926 left review comments

@iamhopaul123 iamhopaul123 iamhopaul123 approved these changes

@dannyrandall dannyrandall dannyrandall approved these changes

@KollaAdithya KollaAdithya Awaiting requested review from KollaAdithya KollaAdithya is a code owner automatically assigned from aws/aws-ecs-devx

@efekarakus efekarakus Awaiting requested review from efekarakus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Varun359 @codecov-commenter @dannyrandall @iamhopaul123 @Lou1415926