Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply all PublicAccessBlockConfiguration for all s3 buckets #5130

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

iamhopaul123
Copy link
Contributor

Fixes #5089

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.

@iamhopaul123 iamhopaul123 requested a review from a team as a code owner July 25, 2023 22:38
@iamhopaul123 iamhopaul123 requested review from huanjani and removed request for a team July 25, 2023 22:38
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

🍕 Here are the new binary sizes!

Name New size (kiB) size (kiB) Delta (%)
macOS (amd) 51476 51400 +0.15
macOS (arm) 51684 51604 +0.16
linux (amd) 45308 45244 +0.14
linux (arm) 43588 43524 +0.15
windows (amd) 42128 42072 +0.13

@codecov-commenter
Copy link

Codecov Report

Merging #5130 (80fba6e) into mainline (f46a957) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           mainline    #5130      +/-   ##
============================================
- Coverage     69.65%   69.64%   -0.01%     
============================================
  Files           295      295              
  Lines         43108    43108              
  Branches        285      285              
============================================
- Hits          30026    30024       -2     
- Misses        11615    11618       +3     
+ Partials       1467     1466       -1     

see 1 file with indirect coverage changes

Copy link
Contributor

@KollaAdithya KollaAdithya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice! I assume we did not miss any other S3 bucket.

@mergify mergify bot merged commit ac4ded0 into aws:mainline Jul 26, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

copilot pipeline init creates publicly accessible s3 buckets
4 participants