Add api server extra args map to cluster spec #7755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/L
sp1999
force-pushed
the
add-apiserver-flags
branch
from
98d06c4 to
9b88b86
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7755 +/- ##
==========================================
+ Coverage 73.39% 73.43% +0.03%
==========================================
Files 576 576
Lines 35622 35667 +45
==========================================
+ Hits 26144 26191 +47
+ Misses 7826 7823 -3
- Partials 1652 1653 +1 ☔ View full report in Codecov by Sentry. |
sp1999
force-pushed
the
add-apiserver-flags
branch
from
9b88b86 to
75e50bd
Compare
eks-distro-bot
added
size/M
|
/hold |
sp1999
force-pushed
the
add-apiserver-flags
branch
from
75e50bd to
772f9a5
Compare
eks-distro-bot
added
size/L
sp1999
force-pushed
the
add-apiserver-flags
branch
5 times, most recently
from
78b7228 to
07f965f
Compare
eks-distro-bot
added
size/XL
|
/unhold |
test/e2e/cloudstack_test.go
Outdated
Comment on lines
53
to
61
| runApiServerExtraArgsUpgradeFlow( | ||
| test, | ||
| addApiServerExtraArgsclusterOpts, | ||
| removeApiServerExtraArgsclusterOpts, | ||
| ) |
There was a problem hiding this comment.
Good design of specifying multiple upgrades 💯
sp1999
force-pushed
the
add-apiserver-flags
branch
2 times, most recently
from
1e0a265 to
abc6e97
Compare
sp1999
force-pushed
the
add-apiserver-flags
branch
from
d0d64e4 to
afb2396
Compare
sp1999
force-pushed
the
add-apiserver-flags
branch
3 times, most recently
from
5fca95d to
2ce3376
Compare
sp1999
force-pushed
the
add-apiserver-flags
branch
from
2ce3376 to
d3ebbd1
Compare
sp1999
force-pushed
the
add-apiserver-flags
branch
from
d3ebbd1 to
443db14
Compare
sp1999
force-pushed
the
add-apiserver-flags
branch
from
443db14 to
5da79a7
Compare
This reverts commit e4b9ef4.
sp1999
force-pushed
the
add-apiserver-flags
branch
from
5da79a7 to
a8b6a35
Compare
vivek-koppuru
approved these changes
Mar 20, 2024
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2091
Description of changes:
Design doc: #7853
These changes allow for custom configuration of the api server flags in the cluster spec through
spec.controlPlaneConfiguration.APIServerExtraArgs. If specified, this will be added to apiServerExtraArgs for the kubeadm cluster configuration in kcp object. A feature flag needs to be enabled in order to configure the api server flags. No validations are done for any of the flags configured. It is expected from the users that if they are enabling the feature flag, they know what values to configure for the flags.Testing (if applicable):
Documentation added/planned (if applicable):
EKS-A docs need to be updated to add
spec.controlPlaneConfiguration.apiServerExtraArgsas an optional configuration for the cluster specBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.