-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cluster status #8455
Update cluster status #8455
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8455 +/- ##
==========================================
+ Coverage 73.48% 73.49% +0.01%
==========================================
Files 578 578
Lines 36489 36504 +15
==========================================
+ Hits 26814 26829 +15
Misses 7956 7956
Partials 1719 1719 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-0.20 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.19 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sp1999: new pull request created: #8456 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sp1999: new pull request created: #8457 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
#2383
Description of changes:
Added a check on the
Ready
condition for the kcp and md objects as a final validation before marking thecontrolPlaneReady
andworkersReady
condition toTrue
in the cluster status.Testing (if applicable):
make eks-a
make unit-test
make lint
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.