Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HookOS embedded images in Tinkerbell Templates: #8708

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

jacobweinstock
Copy link
Member

Issue #, if available:

Description of changes:
HookOS now embeds the container images for all Tinkerbell Actions into the HookOS Docker cache. As such, we update all Actions to use the embedded image names.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

HookOS now embeds the container images for all Tinkerbell
Actions into the HookOS Docker cache. As such, we update
all Actions to use the embedded image names.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress labels Sep 4, 2024
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2024
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobweinstock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.57%. Comparing base (60152db) to head (b0a782a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/v1alpha1/tinkerbelltemplateconfig.go 0.00% 2 Missing ⚠️
...nywhere/cmd/generate_tinkerbell_template_config.go 0.00% 1 Missing ⚠️
pkg/providers/tinkerbell/template.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8708      +/-   ##
==========================================
+ Coverage   73.55%   73.57%   +0.02%     
==========================================
  Files         578      578              
  Lines       36580    36629      +49     
==========================================
+ Hits        26905    26951      +46     
+ Misses       7955     7951       -4     
- Partials     1720     1727       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobweinstock
Copy link
Member Author

/test eks-anywhere-presubmit

@rahulbabu95
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 5b8b789 into aws:main Sep 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants