-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize tinkerbell load balancer interface #8805
Customize tinkerbell load balancer interface #8805
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8805 +/- ##
=======================================
Coverage 73.65% 73.66%
=======================================
Files 578 578
Lines 36610 36618 +8
=======================================
+ Hits 26965 26973 +8
Misses 7919 7919
Partials 1726 1726 ☔ View full report in Codecov by Sentry. |
b10b5ea
to
bc468fc
Compare
7823ccd
to
c6ee101
Compare
c6ee101
to
bd4a7fc
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
#1954
Description of changes:
This PR introduces
loadBalancerInterface
as an optional configuration in theTinkerbellDatacenterConfig
spec in order to allow customers to override the default interface used by the current load-balancer(kube-vip) daemonset for the Tinkerbell stack. It also updates the EKS-A docs for that and adds the corresponding design doc.Testing (if applicable):
Successfully created and upgraded a tinkerbell cluster with a custom
loadBalancerInterface
specified in the cluster spec through the tinkerbell datacenter configDocumentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.