Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize tinkerbell load balancer interface #8805

Merged

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Sep 23, 2024

Issue #, if available:
#1954

Description of changes:
This PR introduces loadBalancerInterface as an optional configuration in the TinkerbellDatacenterConfig spec in order to allow customers to override the default interface used by the current load-balancer(kube-vip) daemonset for the Tinkerbell stack. It also updates the EKS-A docs for that and adds the corresponding design doc.

Testing (if applicable):

make eks-a
make lint
make unit-test
make generate
make generate-manifests
make release-manifests
make build-all-test-binaries
make verify-generate
make verify-generate-manifests

Successfully created and upgraded a tinkerbell cluster with a custom loadBalancerInterface specified in the cluster spec through the tinkerbell datacenter config

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.66%. Comparing base (fe2dad6) to head (bd4a7fc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8805   +/-   ##
=======================================
  Coverage   73.65%   73.66%           
=======================================
  Files         578      578           
  Lines       36610    36618    +8     
=======================================
+ Hits        26965    26973    +8     
  Misses       7919     7919           
  Partials     1726     1726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999 sp1999 force-pushed the customize-tinkerbell-load-balancer-interface branch from b10b5ea to bc468fc Compare September 23, 2024 16:02
@sp1999 sp1999 force-pushed the customize-tinkerbell-load-balancer-interface branch 5 times, most recently from 7823ccd to c6ee101 Compare September 29, 2024 02:36
@sp1999 sp1999 force-pushed the customize-tinkerbell-load-balancer-interface branch from c6ee101 to bd4a7fc Compare September 29, 2024 02:44
@sp1999
Copy link
Member Author

sp1999 commented Sep 29, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit f613daf into aws:main Sep 30, 2024
14 checks passed
@sp1999 sp1999 deleted the customize-tinkerbell-load-balancer-interface branch September 30, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants