-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Failure Domains for Worker nodes feature for Nutanix provider #8837
Conversation
Hi @adiantum. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8837 +/- ##
==========================================
+ Coverage 73.74% 73.77% +0.02%
==========================================
Files 578 578
Lines 36788 36832 +44
==========================================
+ Hits 27130 27173 +43
- Misses 7928 7929 +1
Partials 1730 1730 ☔ View full report in Codecov by Sentry. |
/retest |
2 similar comments
/retest |
/retest |
3360eba
to
2a8bf41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of changes:
Add Failure Domains for Worker nodes feature for Nutanix provider.
Example configuration:
Implementation details: add workerMachineGroups parameter to existing failureDomains. In workerMachineGroups should be list of EKS-A Clusters workerNodeGroupConfigurations names.
Testing (if applicable):
Documentation added/planned (if applicable):
Feature will be documented after merge
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.