Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-node-termination-handler] patch-release is backwards incompatible #546

Closed
mhulscher opened this issue Jun 21, 2021 · 1 comment · Fixed by #1155
Closed

[aws-node-termination-handler] patch-release is backwards incompatible #546

mhulscher opened this issue Jun 21, 2021 · 1 comment · Fixed by #1155
Labels
bug Something isn't working

Comments

@mhulscher
Copy link

Describe the bug
Upgrading helm-chart aws-node-termination-handler from 0.15.0 to 0.15.1 is impossible because of a breaking change.

Error: failed to replace object: RoleBinding.rbac.authorization.k8s.io "aws-node-termination-handler-psp" is invalid: roleRef: Invalid value: rbac.RoleRef{APIGroup:"rbac.authorization.k8s.io", Kind:"Role", Name:"aws-node-termination-handler-psp"}: cannot change roleRef

Steps to reproduce
Upgrade aws-node-termination-handler from 0.15.0 to 0.15.1 with RBAC and PSP enabled.

Expected outcome
Upgrade should work.

Environment

  • Chart name: aws-node-termination-handler
  • Chart version: 0.15.0 -> 0.15.1
  • Kubernetes version: 1.19
  • Using EKS (yes/no), if so version? v1.19.8-eks-96780e

Additional Context:

N/A
@mhulscher mhulscher added the bug Something isn't working label Jun 21, 2021
timothy-spencer added a commit to 18F/identity-gitlab that referenced this issue Jun 23, 2021
@timothy-spencer
cannot upgrade node termination handler right now: aws/eks-charts#546
7967168
timothy-spencer added a commit to 18F/identity-gitlab that referenced this issue Jun 24, 2021
@timothy-spencer
Updating stuff (#40)
d966518 
* Add Flux v0.15.0 component manifests

* Add Flux sync manifests

* added documentation, fixed branch/git pull method up.

* update new versions of everything except gitlab

* cannot upgrade node termination handler right now: aws/eks-charts#546

Co-authored-by: Flux <>
@bwagner5
Copy link
Collaborator

bwagner5 commented Jul 2, 2021

Apologies for the inconvenience here. We do not have helm upgrade tests for NTH, so I think that would be a good addition to make sure this doesn't happen again. Uninstalling and reinstalling the chart should work fine to upgrade.

@bryantbiggs bryantbiggs mentioned this issue Sep 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@bwagner5 @mhulscher