Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional endpoint configuration for ServiceMonitor #1073

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jmonson
Copy link

@jmonson jmonson commented Mar 12, 2024

Issue

Added additional endpoint configuration for ServiceMonitor

Description of changes

Added the following configuration options for ServiceMonitor:

  scrapeTimeout:
  # If set overrides the _Prometheus_ default scheme.
  scheme:
  # Configure the `ServiceMonitor` [TLS config](https://github.com/coreos/prometheus-operator/blob/master/Documentation/api.md#tlsconfig).
  tlsConfig: {}
  # Provide a bearer token file for the `ServiceMonitor`.
  bearerTokenFile:
  # [Relabel configs](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#relabel_config) to apply to samples before ingestion.
  relabelings: []
  # [Metric relabel configs](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#metric_relabel_configs) to apply to samples before ingestion.
  metricRelabelings: []

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

Manually tested helm deployments with and without changes to values in serviceMonitor section.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmonson jmonson requested a review from M00nF1sh as a code owner March 12, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants