Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate aws-load-balancer-controller in favor of moving to upstream repository #1172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryantbiggs
Copy link
Member

Issue

Description of changes

  • Deprecate aws-load-balancer-controller in favor of moving to upstream repository

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@oliviassss
Copy link
Collaborator

oliviassss commented Oct 18, 2024

@bryantbiggs, hi, can you elaborate more on the decision process? Why deprecating?

@M00nF1sh
Copy link
Contributor

M00nF1sh commented Oct 18, 2024

Hi,
we shouldn't deprecate the aws-load-balancer-controller chart at this moment.
This has been our primary source to host the chart and there are customers relies on this.

The helm charts in the https://github.com/kubernetes-sigs/aws-load-balancer-controller repo is simply a source, where we sync to this eks-charts repo periodically for publish it.

Eventually we'd like to move to public ECR to host helm charts, but it's not ready yet, and we need carefully do the transition.

@M00nF1sh M00nF1sh closed this Oct 18, 2024
@bryantbiggs bryantbiggs reopened this Oct 18, 2024
@bryantbiggs
Copy link
Member Author

@bryantbiggs, hi, can you elaborate more on the decision process? Why deprecating?

yes! the source of truth lies in the AWS LBC repo and this is merely a legacy artifact for publishing purposes. However, that also means it lacks a true owner and questions go unanswered here (see linked issues and PRs. with Public ECR, the better approach is to keep everything in the main repo (the AWS LBC repo) and simply publish to Public ECR from there. this keeps the artifacts in one location, the ownership is clearly defined, and customers/users know where to go for issues/questions/PRs

we aren't making any changes here until the upstream projects have started publishing directly from their repository(s) to Public ECR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment