Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement toxicity eval algo #48

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Conversation

malhotra18
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

src/amazon_fmeval/eval_algorithms/__init__.py Show resolved Hide resolved
src/amazon_fmeval/eval_algorithms/toxicity.py Outdated Show resolved Hide resolved
src/amazon_fmeval/eval_algorithms/toxicity.py Outdated Show resolved Hide resolved
src/amazon_fmeval/eval_algorithms/toxicity.py Show resolved Hide resolved
test/unit/eval_algorithms/test_helper_model.py Outdated Show resolved Hide resolved
test/unit/eval_algorithms/test_helper_model.py Outdated Show resolved Hide resolved
franluca
franluca previously approved these changes Oct 18, 2023
src/amazon_fmeval/eval_algorithms/toxicity.py Show resolved Hide resolved
src/amazon_fmeval/eval_algorithms/toxicity.py Outdated Show resolved Hide resolved
src/amazon_fmeval/eval_algorithms/toxicity.py Show resolved Hide resolved
keerthanvasist
keerthanvasist previously approved these changes Oct 18, 2023
Copy link
Member

@keerthanvasist keerthanvasist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have some nits.

pyproject.toml Show resolved Hide resolved
src/amazon_fmeval/eval_algorithms/toxicity.py Outdated Show resolved Hide resolved
@malhotra18 malhotra18 dismissed stale reviews from keerthanvasist and franluca via cdcec3c October 18, 2023 18:25
Copy link
Member

@keerthanvasist keerthanvasist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging as previous commit has approvals.

@keerthanvasist keerthanvasist merged commit 0757011 into aws:main Oct 18, 2023
2 checks passed
@malhotra18 malhotra18 deleted the toxigen branch October 18, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants