fix: typesVersions not respecting outDir from tsconfig file #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrgrain
force-pushed
the
mrgrain/fix/downleveled-types-version-ignores-outdir
branch
from
2428b6e
to
70c4778
Compare
mrgrain
force-pushed
the
mrgrain/fix/downleveled-types-version-ignores-outdir
branch
from
70c4778
to
4f22c75
Compare
mrgrain
commented
Aug 13, 2024
There was a problem hiding this comment.
yikes! We did not have any tests for this before 🙈
kaizencc
approved these changes
Aug 13, 2024
aws-cdk-automation
deleted the
mrgrain/fix/downleveled-types-version-ignores-outdir
branch
aws-cdk-automation
pushed a commit
that referenced
this pull request
Aug 13, 2024
Fixes #1234 Also fixes an issue related the `.type-compat` output path that was discovered when adding tests. When getting `outdir` from the program, this might be either a relative or absolute path. Previously the code assumed it was always relative which is not correct. This led to absolute paths being used for the `.type-compat` dir and in the post processing; ultimately leading to a compilation failure. The fix is to ensure `outdir` & `.type-compat` are normalized to a relative path. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 072239b)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
…1238) (#1243) # Backport This will backport the following commits from `main` to `maintenance/v5.3`: - [fix: typesVersions not respecting outDir from tsconfig file (#1238)](#1238) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Momo Kornher <kornherm@amazon.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1234
Also fixes an issue related the
.type-compatoutput path that was discovered when adding tests. When gettingoutdirfrom the program, this might be either a relative or absolute path. Previously the code assumed it was always relative which is not correct. This led to absolute paths being used for the.type-compatdir and in the post processing; ultimately leading to a compilation failure. The fix is to ensureoutdir&.type-compatare normalized to a relative path.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.