fix: lib setting from custom config is ignored
#1576
Merged
+72
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user provides a custom `tsconfig.json` file, they have the ability to override the `lib` setting, which provides a number of libraries that should be loaded at compile time. This config setting is not passed directly into the TypeScript compiler. Instead, it is resolved and translated into a list of `.d.ts` file that are passed as `rootNames` to the compiler, along with the actual source files. In that resolution, we failed to look at the `lib` setting the user provided, and instead always reverted to the default config. Fix by looking at the user-provided config, falling back to the default config only if the user config doesn't have a `lib` setting (mirroring the behavior of tsc). Fixes #4706.
mrgrain
approved these changes
Dec 13, 2024
aws-cdk-automation
pushed a commit
that referenced
this pull request
Dec 13, 2024
When a user provides a custom `tsconfig.json` file, they have the ability to override the `lib` setting, which provides a number of libraries that should be loaded at compile time. This config setting is not passed directly into the TypeScript compiler. Instead, it is resolved and translated into a list of `.d.ts` file that are passed as `rootNames` to the compiler, along with the actual source files. In that resolution, we failed to look at the `lib` setting the user provided, and instead always used the default config. Fix by looking at the user-provided config, falling back to the default config only if the user config doesn't have a `lib` setting (mirroring the behavior of tsc). Fixes aws/jsii#4706. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 26a3d96)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Dec 13, 2024
When a user provides a custom `tsconfig.json` file, they have the ability to override the `lib` setting, which provides a number of libraries that should be loaded at compile time. This config setting is not passed directly into the TypeScript compiler. Instead, it is resolved and translated into a list of `.d.ts` file that are passed as `rootNames` to the compiler, along with the actual source files. In that resolution, we failed to look at the `lib` setting the user provided, and instead always used the default config. Fix by looking at the user-provided config, falling back to the default config only if the user config doesn't have a `lib` setting (mirroring the behavior of tsc). Fixes aws/jsii#4706. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 26a3d96)
aws-cdk-automation
pushed a commit
that referenced
this pull request
Dec 13, 2024
When a user provides a custom `tsconfig.json` file, they have the ability to override the `lib` setting, which provides a number of libraries that should be loaded at compile time. This config setting is not passed directly into the TypeScript compiler. Instead, it is resolved and translated into a list of `.d.ts` file that are passed as `rootNames` to the compiler, along with the actual source files. In that resolution, we failed to look at the `lib` setting the user provided, and instead always used the default config. Fix by looking at the user-provided config, falling back to the default config only if the user config doesn't have a `lib` setting (mirroring the behavior of tsc). Fixes aws/jsii#4706. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0 (cherry picked from commit 26a3d96)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
) # Backport This will backport the following commits from `main` to `maintenance/v5.6`: - [fix: `lib` setting from custom config is ignored (#1576)](#1576) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
) # Backport This will backport the following commits from `main` to `maintenance/v5.4`: - [fix: `lib` setting from custom config is ignored (#1576)](#1576) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
) # Backport This will backport the following commits from `main` to `maintenance/v5.5`: - [fix: `lib` setting from custom config is ignored (#1576)](#1576) <!--- Backport version: 9.5.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) Co-authored-by: Rico Hermans <rix0rrr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user provides a custom
tsconfig.jsonfile, they have the ability to override thelibsetting, which provides a number of libraries that should be loaded at compile time.This config setting is not passed directly into the TypeScript compiler. Instead, it is resolved and translated into a list of
.d.tsfile that are passed asrootNamesto the compiler, along with the actual source files.In that resolution, we failed to look at the
libsetting the user provided, and instead always used the default config.Fix by looking at the user-provided config, falling back to the default config only if the user config doesn't have a
libsetting (mirroring the behavior of tsc).Fixes aws/jsii#4706.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.