chore(release): 1.74.0 (#3941)

See [CHANGELOG](https://github.com/aws/jsii/blob/bump/1.74.0/CHANGELOG.md)
aws · Jan 28, 2023 · 6d08790 · 6d08790
2 parents 6faeda3 + 7f20d99
commit 6d08790
Show file tree

Hide file tree

Showing 38 changed files with 582 additions and 283 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,14 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [1.74.0](https://github.com/aws/jsii/compare/v1.73.0...v1.74.0) (2023-01-28)
+
+
+### Bug Fixes
+
+* **python:** returning Promise<void> breaks runtime ([#3916](https://github.com/aws/jsii/issues/3916)) ([209d10e](https://github.com/aws/jsii/commit/209d10eab284b4e8ad38e37c0d4b4bf3294569c4))
+* **rosetta:** Rosetta does not support `await` ([#3915](https://github.com/aws/jsii/issues/3915)) ([e4c51c4](https://github.com/aws/jsii/commit/e4c51c43ca5c37ea7c40ed13ebcf3f94f5da4299))
+
 ## [1.73.0](https://github.com/aws/jsii/compare/v1.72.0...v1.73.0) (2023-01-04)
 
 ## [1.72.0](https://github.com/aws/jsii/compare/v1.71.0...v1.72.0) (2022-12-05)

diff --git a/gh-pages/content/specification/6-compliance-report.md b/gh-pages/content/specification/6-compliance-report.md
@@ -5,7 +5,7 @@
 This section details the current state of each language binding with respect to our standard compliance suite.
 
 
-| number | test                                                                                                                                                             | java (98.36%) | golang (79.51%)                              | Dotnet | Python |
+| number | test                                                                                                                                                             | java (97.56%) | golang (78.86%)                              | Dotnet | Python |
 | ------ | ---------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------- | -------------------------------------------- | ------ | ------ |
 | 1      | asyncOverrides_overrideCallsSuper                                                                                                                                | 🟢            | [🔴](https://github.com/aws/jsii/issues/2670) | ⭕      | ⭕      |
 | 2      | [arrayReturnedByMethodCanBeRead]("Array created in the kernel can be queried for its elements")                                                                  | 🟢            | 🟢                                           | ⭕      | ⭕      |
@@ -129,3 +129,4 @@ This section details the current state of each language binding with respect to
 | 120    | [downcasting]("Ensures unsafe-cast features work as expected")                                                                                                   | ⭕             | 🟢                                           | ⭕      | ⭕      |
 | 121    | [strippedDeprecatedMemberCanBeReceived]("Ensures --strip-deprecated does not cause odd runtime errors")                                                          | 🟢            | 🟢                                           | ⭕      | ⭕      |
 | 122    | [exceptionMessage]("Verifies that custom exception names are correctly forwarded")                                                                               | 🟢            | 🟢                                           | ⭕      | ⭕      |
+| 123    | [voidReturningAsync]("Verifies that returning Promise<void> is correctly handled")                                                                               | ⭕             | ⭕                                            | ⭕      | ⭕      |
diff --git a/gh-pages/requirements-dev.txt b/gh-pages/requirements-dev.txt
@@ -1,4 +1,4 @@
 mkdocs~=1.4.2
 mkdocs-awesome-pages-plugin~=2.8.0
-mkdocs-material~=8.5.11
+mkdocs-material~=9.0.6
 mkdocs-git-revision-date-plugin~=0.3.2
diff --git a/lerna.json b/lerna.json
@@ -10,5 +10,5 @@
       "rejectCycles": true
     }
   },
-  "version": "1.73.0"
+  "version": "1.74.0"
 }
diff --git a/package.json b/package.json
@@ -16,13 +16,13 @@
   },
   "devDependencies": {
     "@jest/types": "^28.1.3",
-    "@types/jest": "^29.2.4",
+    "@types/jest": "^29.2.5",
     "@types/node": "^14.18.36",
-    "@typescript-eslint/eslint-plugin": "^5.47.1",
-    "@typescript-eslint/parser": "^5.47.1",
+    "@typescript-eslint/eslint-plugin": "^5.48.0",
+    "@typescript-eslint/parser": "^5.48.0",
     "all-contributors-cli": "^6.24.0",
-    "eslint": "^8.30.0",
-    "eslint-config-prettier": "^8.5.0",
+    "eslint": "^8.31.0",
+    "eslint-config-prettier": "^8.6.0",
     "eslint-import-resolver-node": "^0.3.6",
     "eslint-import-resolver-typescript": "^3.5.2",
     "eslint-plugin-import": "^2.26.0",

diff --git a/packages/@jsii/Directory.Build.targets b/packages/@jsii/Directory.Build.targets
@@ -7,7 +7,7 @@
     <PackageReference Update="Microsoft.Extensions.Logging.Console" Version="5.0.0" />
 
     <PackageReference Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.4.0" />
-    <PackageReference Update="Microsoft.CodeAnalysis.Analyzers" Version="3.3.3" />
+    <PackageReference Update="Microsoft.CodeAnalysis.Analyzers" Version="3.3.4" />
     <PackageReference Update="Microsoft.CodeQuality.Analyzers" Version="3.3.2" />
 
     <PackageReference Update="Microsoft.NET.Test.Sdk" Version="17.4.1" />

diff --git a/packages/@jsii/go-runtime-test/project/go.mod b/packages/@jsii/go-runtime-test/project/go.mod
@@ -9,7 +9,7 @@ require (
 	github.com/aws/jsii/jsii-calc/go/scopejsiicalclib v0.0.0-devpreview
 	github.com/stretchr/testify v1.8.1
 	golang.org/x/lint v0.0.0-20210508222113-6edffad5e616
-	golang.org/x/tools v0.4.0
+	golang.org/x/tools v0.5.0
 )
 
 require (
@@ -20,7 +20,7 @@ require (
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/yuin/goldmark v1.4.13 // indirect
 	golang.org/x/mod v0.7.0 // indirect
-	golang.org/x/sys v0.3.0 // indirect
+	golang.org/x/sys v0.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 

diff --git a/packages/@jsii/go-runtime-test/project/go.sum b/packages/@jsii/go-runtime-test/project/go.sum
@@ -34,12 +34,16 @@ golang.org/x/sys v0.2.0 h1:ljd4t30dBnAvMZaQCevtY0xLLD0A+bRZXbgLMLU1F/A=
 golang.org/x/sys v0.2.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.3.0 h1:w8ZOecv6NaNa/zC8944JTU3vz4u6Lagfk4RPQxv92NQ=
 golang.org/x/sys v0.3.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.4.0 h1:Zr2JFtRQNX3BCZ8YtxRE9hNJYC8J6I1MVbMg6owUp18=
+golang.org/x/sys v0.4.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/tools v0.0.0-20200130002326-2f3ba24bd6e7/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28=
 golang.org/x/tools v0.3.0 h1:SrNbZl6ECOS1qFzgTdQfWXZM9XBkiA6tkFrH9YSTPHM=
 golang.org/x/tools v0.3.0/go.mod h1:/rWhSS2+zyEVwoJf8YAX6L2f0ntZ7Kn/mGgAWcipA5k=
 golang.org/x/tools v0.4.0 h1:7mTAgkunk3fr4GAloyyCasadO6h9zSsQZbwvcaIciV4=
 golang.org/x/tools v0.4.0/go.mod h1:UE5sM2OK9E/d67R0ANs2xJizIymRP5gJU295PvKXxjQ=
+golang.org/x/tools v0.5.0 h1:+bSpV5HIeWkuvgaMfI3UmKRThoTA5ODJTUd8T17NO+4=
+golang.org/x/tools v0.5.0/go.mod h1:N+Kgy78s5I24c24dU8OfWNEotWjutIs8SnJvn5IDq+k=
 golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

diff --git a/packages/@jsii/go-runtime/jsii-runtime-go/go.mod b/packages/@jsii/go-runtime/jsii-runtime-go/go.mod
@@ -7,15 +7,15 @@ require (
 	github.com/mattn/go-isatty v0.0.16
 	github.com/stretchr/testify v1.8.1
 	golang.org/x/lint v0.0.0-20210508222113-6edffad5e616
-	golang.org/x/tools v0.4.0
+	golang.org/x/tools v0.5.0
 )
 
 require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	github.com/yuin/goldmark v1.4.13 // indirect
 	golang.org/x/mod v0.7.0 // indirect
-	golang.org/x/sys v0.3.0 // indirect
+	golang.org/x/sys v0.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )
 

diff --git a/packages/@jsii/go-runtime/jsii-runtime-go/go.sum b/packages/@jsii/go-runtime/jsii-runtime-go/go.sum
@@ -30,12 +30,12 @@ golang.org/x/sync v0.1.0 h1:wsuoTGHzEhffawBOhz5CYhcrV4IdKZbEyZjBMuTp12o=
 golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
 golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
 golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
-golang.org/x/sys v0.3.0 h1:w8ZOecv6NaNa/zC8944JTU3vz4u6Lagfk4RPQxv92NQ=
-golang.org/x/sys v0.3.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
+golang.org/x/sys v0.4.0 h1:Zr2JFtRQNX3BCZ8YtxRE9hNJYC8J6I1MVbMg6owUp18=
+golang.org/x/sys v0.4.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 golang.org/x/tools v0.0.0-20200130002326-2f3ba24bd6e7/go.mod h1:TB2adYChydJhpapKDTa4BR/hXlZSLoq2Wpct/0txZ28=
-golang.org/x/tools v0.4.0 h1:7mTAgkunk3fr4GAloyyCasadO6h9zSsQZbwvcaIciV4=
-golang.org/x/tools v0.4.0/go.mod h1:UE5sM2OK9E/d67R0ANs2xJizIymRP5gJU295PvKXxjQ=
+golang.org/x/tools v0.5.0 h1:+bSpV5HIeWkuvgaMfI3UmKRThoTA5ODJTUd8T17NO+4=
+golang.org/x/tools v0.5.0/go.mod h1:N+Kgy78s5I24c24dU8OfWNEotWjutIs8SnJvn5IDq+k=
 golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=

diff --git a/packages/@jsii/java-runtime/project/src/main/java/software/amazon/jsii/Kernel.java b/packages/@jsii/java-runtime/project/src/main/java/software/amazon/jsii/Kernel.java
@@ -36,7 +36,7 @@ public static <T> T asyncCall(final Object receiver, final String method, final
     /**
      * Calls a JavaScript method on a receiver.
      *
-     * @param receiver the receiver for hte method call
+     * @param receiver the receiver for the method call
      * @param method The name of the method.
      * @param nativeType The return type.
      * @param args Method arguments.

diff --git a/packages/@jsii/python-runtime/package.json b/packages/@jsii/python-runtime/package.json
@@ -42,6 +42,6 @@
     "jsii-build-tools": "^0.0.0",
     "jsii-calc": "^3.20.120",
     "jsii-pacmak": "^0.0.0",
-    "pyright": "^1.1.286"
+    "pyright": "^1.1.287"
   }
 }
diff --git a/packages/@jsii/python-runtime/src/jsii/_kernel/types.py b/packages/@jsii/python-runtime/src/jsii/_kernel/types.py
@@ -185,7 +185,7 @@ class EndRequest:
 @attr.s(auto_attribs=True, frozen=True, slots=True)
 class EndResponse:
 
-    result: Any
+    result: Optional[Any] = None
 
 
 @attr.s(auto_attribs=True, frozen=True, slots=True)

diff --git a/packages/@jsii/python-runtime/tests/test_compliance.py b/packages/@jsii/python-runtime/tests/test_compliance.py
@@ -76,6 +76,7 @@
     StructParameterType,
     AnonymousImplementationProvider,
     UpcasingReflectable,
+    PromiseNothing,
 )
 from jsii_calc.cdk16625 import Cdk16625
 from jsii_calc.cdk22369 import AcceptsPath
@@ -1354,3 +1355,11 @@ def test_stripped_deprecated_member_can_be_received():
 def test_exception_message():
     with pytest.raises(RuntimeError, match="Cannot find asset"):
         AcceptsPath(source_path="A Bad Path")
+
+
+def test_void_returning_async():
+    """Verifies it's okay to return a Promise<void>."""
+
+    assert PromiseNothing().instance_promise_it() is None
+    ## TODO: This is currently broken as code-gen is incorrect for static async.
+    # assert PromiseNothing.promise_it() is None
diff --git a/packages/@jsii/spec/package.json b/packages/@jsii/spec/package.json
@@ -31,7 +31,7 @@
     "package": "package-js"
   },
   "dependencies": {
-    "ajv": "^8.11.2"
+    "ajv": "^8.12.0"
   },
   "devDependencies": {
     "fs-extra": "^10.1.0",

diff --git a/packages/jsii-calc/lib/compliance.ts b/packages/jsii-calc/lib/compliance.ts
@@ -3131,3 +3131,13 @@ export interface ParamShadowsBuiltinsProps {
   readonly booleanProperty: boolean;
   readonly structProperty: StructA;
 }
+
+export class PromiseNothing {
+  public static async promiseIt(): Promise<void> {
+    return Promise.resolve();
+  }
+
+  public async instancePromiseIt(): Promise<void> {
+    return PromiseNothing.promiseIt();
+  }
+}
diff --git a/packages/jsii-calc/test/assembly.jsii b/packages/jsii-calc/test/assembly.jsii
@@ -11823,6 +11823,50 @@
       ],
       "symbolId": "lib/calculator:Power"
     },
+    "jsii-calc.PromiseNothing": {
+      "assembly": "jsii-calc",
+      "docs": {
+        "stability": "stable"
+      },
+      "fqn": "jsii-calc.PromiseNothing",
+      "initializer": {
+        "docs": {
+          "stability": "stable"
+        }
+      },
+      "kind": "class",
+      "locationInModule": {
+        "filename": "lib/compliance.ts",
+        "line": 3135
+      },
+      "methods": [
+        {
+          "async": true,
+          "docs": {
+            "stability": "stable"
+          },
+          "locationInModule": {
+            "filename": "lib/compliance.ts",
+            "line": 3136
+          },
+          "name": "promiseIt",
+          "static": true
+        },
+        {
+          "async": true,
+          "docs": {
+            "stability": "stable"
+          },
+          "locationInModule": {
+            "filename": "lib/compliance.ts",
+            "line": 3140
+          },
+          "name": "instancePromiseIt"
+        }
+      ],
+      "name": "PromiseNothing",
+      "symbolId": "lib/compliance:PromiseNothing"
+    },
     "jsii-calc.PropertyNamedProperty": {
       "assembly": "jsii-calc",
       "docs": {
@@ -18799,5 +18843,5 @@
     }
   },
   "version": "3.20.120",
-  "fingerprint": "kmlc5is+t/xffykk7b4m8jurrxFDkj9pjv2cW/V1J50="
+  "fingerprint": "EH7xszNdCh9PCFUZ8Foi7g2CPhdrKeZm8CQaUCNv4GQ="
 }
diff --git a/packages/jsii-config/package.json b/packages/jsii-config/package.json
@@ -20,7 +20,7 @@
   },
   "devDependencies": {
     "@types/inquirer": "^8.2.3",
-    "@types/yargs": "^17.0.17",
+    "@types/yargs": "^17.0.19",
     "jest-expect-message": "^1.1.3"
   },
   "dependencies": {

diff --git a/packages/jsii-pacmak/package.json b/packages/jsii-pacmak/package.json
@@ -65,7 +65,7 @@
     "jsii": "^0.0.0",
     "jsii-build-tools": "^0.0.0",
     "jsii-calc": "^3.20.120",
-    "pyright": "^1.1.286"
+    "pyright": "^1.1.287"
   },
   "keywords": [
     "jsii",

diff --git a/packages/jsii-pacmak/test/generated-code/__snapshots__/target-dotnet.test.js.snap b/packages/jsii-pacmak/test/generated-code/__snapshots__/target-dotnet.test.js.snap