Skip to content

Commit

Permalink
chore(go): Generate inherited methods on class (#1965)
Browse files Browse the repository at this point in the history
Previously, GoClass methods were only being populated by methods
directly on the parent type. Calling `getMethods` with true also
gets any inherited methods, which should cause the class to correctly
implement its corresponding interface.
  • Loading branch information
SoManyHs authored Aug 27, 2020
1 parent ded1d26 commit 78b7b7d
Show file tree
Hide file tree
Showing 2 changed files with 260 additions and 20 deletions.
2 changes: 1 addition & 1 deletion packages/jsii-pacmak/lib/targets/golang/types/class.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class GoClass extends GoStruct {
public constructor(parent: Package, public type: ClassType) {
super(parent, type);

this.methods = Object.values(this.type.getMethods()).map(
this.methods = Object.values(this.type.getMethods(true)).map(
(method) => new ClassMethod(this, method),
);
}
Expand Down
Loading

0 comments on commit 78b7b7d

Please sign in to comment.