-
Notifications
You must be signed in to change notification settings - Fork 244
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(assembler): handle unknown types without crashing (#501)
After failing compilation we proceed with jsii analysis, to give as much information as possible in one go. However, some compilation failures lead to a lack of information that make the jsii analyzer crash, which ultimately leads jsii to fail with no more information than: Error: TypeError: Cannot read property 'getJsDocTags' of undefined Fix this in two ways: - First, detect the situation where this occurs and produce a more useful error message. - Guard against this happening in general by catching exceptions during type analysis and still printing the compilation errors.
- Loading branch information
Showing
2 changed files
with
44 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters