Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dotnet): update TargetFramework to net6.0 #3957

Merged
merged 11 commits into from
Feb 17, 2023

Conversation

berviantoleo
Copy link
Contributor

@berviantoleo berviantoleo commented Feb 11, 2023

BREAKING CHANGE: The runtime library for .NET & generated .NET bindings will no longer support netcoreapp3.1 after this release. Users are advised to upgrade their apps to use net6.0 or net7.0 instead.

Related: aws/aws-cdk#23926
Related: aws/aws-cdk#23921


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@berviantoleo berviantoleo marked this pull request as ready for review February 12, 2023 03:22
@RomainMuller
Copy link
Contributor

We'll also need to update the various documentation points mentioning .NET 3.1 as the minimum supported, the Mergify configuration file, and our branch protection rules. I'll try to have a look into these later this week.

@RomainMuller RomainMuller self-assigned this Feb 14, 2023
@RomainMuller RomainMuller changed the title feat: Update tools to use net6.0 feat: update TargetFramework to net6.0 Feb 16, 2023
RomainMuller
RomainMuller previously approved these changes Feb 16, 2023
@berviantoleo
Copy link
Contributor Author

Thank you for helping me to update the rest.

@RomainMuller
Copy link
Contributor

@berviantoleo you're welcome. Thanks for kicking that into motion ;-)

@mergify mergify bot dismissed RomainMuller’s stale review February 16, 2023 18:37

Pull request has been modified.

@RomainMuller
Copy link
Contributor

Due to changes in branch protection, etc... this is going to need hand-merging... I'll get to this tomorrow, as the other PRs that ware ahead of this one are now merged.

@RomainMuller RomainMuller changed the title feat: update TargetFramework to net6.0 feat(dotnet): update TargetFramework to net6.0 Feb 17, 2023
@RomainMuller RomainMuller merged commit ae335ed into aws:main Feb 17, 2023
@Altdarkzodiac
Copy link

Good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants