Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Upgrade init template to .NET 6.0 #2673

Merged
merged 9 commits into from
Mar 3, 2023
Merged

feat(cli): Upgrade init template to .NET 6.0 #2673

merged 9 commits into from
Mar 3, 2023

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Feb 23, 2023

No description provided.

@ansgarm
Copy link
Member Author

ansgarm commented Feb 23, 2023

This still needs some fix (printing less warnings) to the documentation example

@ansgarm
Copy link
Member Author

ansgarm commented Feb 24, 2023

Okay, so we still need JSII to release a new version with this PR included before we can merge this change.
The underlying reason is that we get a lot of warnings in the form of

/Users/ansgar/.nuget/packages/microsoft.extensions.dependencyinjection.abstractions/7.0.0/buildTransitive/netcoreapp2.0/Microsoft.Extensions.DependencyInjection.Abstractions.targets(4,5): warning : Microsoft.Extensions.DependencyInjection.Abstractions 7.0.0 doesn't support netcoreapp3.1 and has not been tested with it. Consider upgrading your TargetFramework to net6.0 or later. You may also set <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> in the project file to ignore this warning and attempt to run in this unsupported configuration at your own risk. [/Users/ansgar/projects/hashicorp/terraform-cdk/examples/csharp/documentation/.gen/kubernetes/kubernetes.csproj]

which stem from the generated bindings still targetting the older .NET version – something that is fixed by the upstream JSII PR.

To get our documentation example to work, we'd need to adjust that generated code which would be very hacky (and is the reason why we can't update our C# template just yet).

I'll find a different way to fix this in the meantime and keep this PR waiting until we have a new JSII release.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants