-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest jsii-rosetta package is not used. #4098
Comments
I'm having this issue as well. jsii-config 1.82.0 MacBook M1 with Ventura 13.4 running in docker container: |
Workaround for fixing this with
Then |
For "resolutions": {
"jsii-rosetta": "~5.1.0"
}, but this results in |
I am experiencing this problem as well. |
…4487) Fixes #4098 Previously jsii-pacmak depended on jsii-rosetta 1.x. This is problematic if a different version of the jsii compiler was used, because it introduced different versions of TypeScript into the project. With this PR, the dependency is changed to a peer dependency. Thus allowing any compatible version jsii-rosetta to be used. BREAKING CHANGE: jsii-pacmak now has a peer dependency on jsii-rosetta. Please ensure a version of jsii-rosetta matching your version of jsii is available. Most package managers install peer dependencies automatically and no change is required. However users of yarn v1 or npm v3 to v6 must install jsii-rosetta manually. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
This issue is now closed. Comments on closed issues are hard for our team to see. |
Describe the bug
jsii-rosetta moved to another repository and v5.0.x is released, but packages in this repository, such as jsii-pacmak, seems to depend on the old package.
Expected Behavior
jsii-pacmak depends on jsii-rosetta latest release(currently v5.0.7).
Current Behavior
jsii-pacmak depends on jsii-rosetta v1.81.0.
Reproduction Steps
In empty directory, running
npm i jsii-pacmak && npm ls --all
will shows following results:But jsii-rosetta@5.0.7 should be installed.
(And running
npx jsii-pacmak
shows deprecation error even though installed latest jsii-pacmak.)
Possible Solution
No response
Additional Information/Context
No response
SDK version used
1.18.0
Environment details (OS name and version, etc.)
Linux acm-envy3-win 5.15.90.1-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 GNU/Linux
The text was updated successfully, but these errors were encountered: