Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET Nuget packages should have an icon #773

Closed
assyadh opened this issue Sep 11, 2019 · 3 comments · Fixed by #797
Closed

.NET Nuget packages should have an icon #773

assyadh opened this issue Sep 11, 2019 · 3 comments · Fixed by #797
Assignees
@assyadh
Labels
bug This issue is a bug. language/dotnet Related to .NET bindings (C#, F#, ...) needs-triage This issue or PR still needs to be triaged. p0

Comments

@assyadh
Copy link
Contributor

assyadh commented Sep 11, 2019

The packages right now lack icons in Nuget/nuget gallery.

Example:

https://www.nuget.org/packages/Amazon.JSII.Analyzers/

We can just use the SDK one.
@assyadh assyadh added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 11, 2019
@assyadh assyadh added this to the .NET Support milestone Sep 11, 2019
@assyadh assyadh self-assigned this Sep 11, 2019
@assyadh assyadh added p0 language/dotnet Related to .NET bindings (C#, F#, ...) labels Sep 11, 2019
@assyadh assyadh mentioned this issue Sep 11, 2019
Merged
@assyadh
Copy link
Contributor Author

assyadh commented Sep 11, 2019

Updated the generator to include a PackageIconUrl node based on the package.json of the CDK construct.

Remaining work is to backfill all the CDK constructs with https://sdk-for-net.amazonwebservices.com/images/AWSLogo128x128.png

@RomainMuller RomainMuller mentioned this issue Sep 16, 2019
Merged
@RomainMuller
Copy link
Contributor

We don't have a dedicated icon for jsii as of yet, though.

@assyadh
Copy link
Contributor Author

assyadh commented Sep 16, 2019

Right, we can use the CDK one for the CDK constructs, but for Jsii related packages, one will be needed.

@RomainMuller RomainMuller mentioned this issue Sep 19, 2019
Merged
@mergify mergify bot closed this as completed in #797 Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@assyadh assyadh

Labels
bug This issue is a bug. language/dotnet Related to .NET bindings (C#, F#, ...) needs-triage This issue or PR still needs to be triaged. p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: configure AWS logo for NuGet packages aws/jsii
2 participants
@RomainMuller @assyadh