Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: configure iconUrl for dotnet packages #4094

Merged
merged 4 commits into from
Sep 17, 2019
Merged

chore: configure iconUrl for dotnet packages #4094

merged 4 commits into from
Sep 17, 2019

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Sep 16, 2019 •
edited by eladb
Loading

This enhances a consistent branding experience across the CDK surface.

This is related to aws/jsii#773

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@RomainMuller
chore: configure iconUrl for dotnet packages
370ce9a 
This enhances a consistent brnading experience across the CDK surface.
@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

eladb
eladb suggested changes Sep 16, 2019
View reviewed changes
packages/@aws-cdk/alexa-ask/package.json Outdated
@@ -12,7 +12,8 @@
"packageId": "Amazon.CDK.Alexa.Ask",
"signAssembly": true,
"assemblyOriginatorKeyFile": "../../key.snk",
"versionSuffix": "-devpreview"
"versionSuffix": "-devpreview",
"iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/png/AWS-Cloud-Development-Kit_Icon_64_Squid.png"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should create a copy of this file in some other location in the repo (e.g. logo/nuget-package-icon.png).

Copy link
Contributor Author

@RomainMuller RomainMuller Sep 16, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking the same & am glad you're bringing this up!

How about logo/default-64-dark.png, so that's a direct/simple way to get a "dark" version of the logo in "64px" resolution. You onboard with that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be evident that this is consumed by the package managers so people don’t take an initiative and rename this thinking it’s just some files sitting around.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@RomainMuller RomainMuller self-assigned this Sep 16, 2019
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit 94e05a7 into master Sep 17, 2019
@mergify mergify bot deleted the rmuller/nuget-icons branch September 17, 2019 17:53
eladb pushed a commit that referenced this pull request Sep 23, 2019
@RomainMuller
chore: configure iconUrl for dotnet packages (#4094)
0ffe2fa 
* chore: configure iconUrl for dotnet packages

This enhances a consistent brnading experience across the CDK surface.

* simplify icon path
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@garnaat garnaat Awaiting requested review from garnaat

@nija-at nija-at Awaiting requested review from nija-at

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

@shivlaks shivlaks Awaiting requested review from shivlaks

@skinny85 skinny85 Awaiting requested review from skinny85

@SoManyHs SoManyHs Awaiting requested review from SoManyHs

Assignees

@RomainMuller RomainMuller

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomainMuller @aws-cdk-automation @eladb @NGL321