Fix module loading on systems that use '\' instead of '/' as the path separator. #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Aug 22, 2018
eladb
pushed a commit
that referenced
this pull request
Aug 28, 2018
### Bug Fixes * **jsii-pacmak:** Output .NET build artifacts to `dist/dotnet/` instead of just `dist/` ([#192](#192)) ([f25c8c4](f25c8c4)) * **jsii-kernel:** Fix module loading on systems that use '\' instead of '/' as the path separator ([#193](#193)) ([9e42991](9e42991)) ### Features * **jsii:** Add check against downgrading properties to readonly ([#201](#201)) ([f60b0ac](f60b0ac))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
packageDiris something likeso\neat, then the code run by_executewill berequire("so\neat"), which fails due to the escape sequence\n.With this change, the code run by
_executewill instead berequire(String.raw`so\neat`).