Java: support abstract return types #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate a $proxy class for all abstract classes and use them when the return type is abstract, similar to interface proxies. This change also adds "abstract: true" to all interface members, so the proxy generator can treat interfaces and classes polymorphically. Added a compliance test "returnAbstract" which verifies this behavior. Fixes #220 Related to #223 (.NET) Related to aws/aws-cdk#680 (require jsii update)
rix0rrr
approved these changes
Sep 12, 2018
mpiroc
suggested changes
Sep 12, 2018
...ii-dotnet-generator/src/Amazon.JSII.Generator/Interface/InterfaceDefaultPropertyGenerator.cs
Outdated
Show resolved
Hide resolved
packages/jsii-dotnet-generator/src/Amazon.JSII.Generator/Interface/InterfaceMethodGenerator.cs
Outdated
Show resolved
Hide resolved
...ages/jsii-dotnet-generator/src/Amazon.JSII.Generator/Interface/InterfacePropertyGenerator.cs
Outdated
Show resolved
Hide resolved
...s/jsii-dotnet-generator/src/Amazon.JSII.Generator/Interface/InterfaceProxyMethodGenerator.cs
Outdated
Show resolved
Hide resolved
...jsii-dotnet-generator/src/Amazon.JSII.Generator/Interface/InterfaceProxyPropertyGenerator.cs
Outdated
Show resolved
Hide resolved
...ed.jsii-calc-lib/java/src/main/java/software/amazon/jsii/tests/calculator/lib/IFriendly.java
Show resolved
Hide resolved
...Amazon.JSII.Tests.CalculatorPackageId/Amazon/JSII/Tests/CalculatorNamespace/AbstractClass.cs
Show resolved
Hide resolved
mpiroc
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate a $proxy class for all abstract classes and use them when the return type is abstract,
similar to interface proxies.
This change also adds
abstract: trueto all interface members, so the proxy generator can treat interfaces and classes polymorphically.Added a compliance test "returnAbstract" which verifies this behavior.
Fixes #220
Related to #223 (.NET)
Related to aws/aws-cdk#680 (require jsii update)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.