feat(jsii): make source map behavior fully configurable #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of enabling declarations maps everywhere as was done in #3521, allow customers to define their desired source-map related configuration in the `jsii.tsc` stanza of `package.json`. This change in stance is motivated by how introduction of declarations map causes broad asset hash changes in consumer code, which effectively breaks many snapshot-based regression tests, and this feature should hence be opt-in.
|
Nudge @andrestone - this will be of interest to you... |
rix0rrr
approved these changes
May 20, 2022
RomainMuller
force-pushed
the
rmuller/user-configurable-source-maps
branch
from
b7edf84
to
3f7b19a
Compare
RomainMuller
force-pushed
the
rmuller/user-configurable-source-maps
branch
from
3f7b19a
to
a269e24
Compare
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of enabling declarations maps everywhere as was done in #3521,
allow customers to define their desired source-map related configuration
in the
jsii.tscstanza ofpackage.json.This change in stance is motivated by how introduction of declarations
map causes broad asset hash changes in consumer code, which effectively
breaks many snapshot-based regression tests, and this feature should
hence be opt-in.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.