feat(python): formally allow dicts to be passed in lieu of structs #3683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formalize the contract that it is allowed to pass a dict in places where a struct instance is expected (this provides less type checking guarantees, and the developer is responsible for passing the right keys in). This should address a false-positive issue with the runtime type-checking introduced in 1.63.0 (#3660).
RomainMuller
force-pushed
the
rmuller/python-struct-as-dict
branch
from
8c9df43
to
fa87557
Compare
Naumel
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formalize the contract that it is allowed to pass a dict in places where
a struct instance is expected (this provides less type checking guarantees,
and the developer is responsible for passing the right keys in).
This should address a false-positive issue with the runtime type-checking
introduced in 1.63.0 (#3660).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.