Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsii): unable to return Promise<void> #3752

Merged
merged 2 commits into from
Sep 19, 2022
Merged

fix(jsii): unable to return Promise<void> #3752

merged 2 commits into from
Sep 19, 2022

Commits on Sep 19, 2022

  1. fix(jsii): unable to return Promise<void> 

    The void-check only accounted for the literal `void` type, but failed
to account for the `Promise<void>` case. This is now fixed.

Fixes #51
    @RomainMuller
    RomainMuller committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    3104a63 View commit details
    Browse the repository at this point in the history

  2. fix snapshots for error messages with improved locality

    @RomainMuller
    RomainMuller committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    35c1476 View commit details
    Browse the repository at this point in the history