Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: copy non-hidden bases when erasing hidden interfaces #392

Merged
merged 4 commits into from
Mar 19, 2019

Conversation

eladb
Copy link
Contributor

@eladb eladb commented Mar 19, 2019

When a type inherits (extends/implements) from a hidden (private/internal)
interface, and that interface extends a non-hidden interface, we need to
copy the non-hidden interface to the consuming type so that it can be polymorphically
used.

Follow up on #390

Co-authored-by: RomainMuller rmuller@amazon.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

When a type inherits (extends/implements) from a hidden (private/internal)
interface, and that interface extends a non-hidden interface, we need to 
copy the non-hidden interface to the consuming type so that it can be polymorphically
used.

Follow up on #390

Co-authored-by: RomainMuller <rmuller@amazon.com>
@eladb eladb requested a review from RomainMuller March 19, 2019 14:59
@eladb eladb requested a review from a team as a code owner March 19, 2019 14:59
@eladb eladb merged commit 5af84b6 into master Mar 19, 2019
@eladb eladb deleted the benisrae/fix-erasure-1 branch March 19, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants