Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(superchain): maven version, docs: CONTRIBUTING.md #4162

Merged
merged 5 commits into from
Jul 4, 2023

Conversation

ysuzuki19
Copy link
Contributor

This PR resolves Issue #4080 and bumps version of the maven from 3.9.2 to 3.9.3.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

mrgrain
mrgrain previously requested changes Jul 3, 2023
CONTRIBUTING.md Outdated
$ IMAGE=superchain
$ docker build -t ${IMAGE} ./superchain
$ docker buildx build -t $IMAGE -f superchain/Dockerfile .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the old instructions here? Assuming they still work?
Open to offering both as alternative options though...

Copy link
Contributor Author

@ysuzuki19 ysuzuki19 Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the idea, but old instruction isn't working.

Because path of some COPY instruction now no longer match (ref).

Do you still want to keep the old one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No that's fine then! Thanks for letting me know!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your response, but I just want to make sure I understand correctly.

Does that mean I can leave the code as it is now?

Copy link
Contributor

@mrgrain mrgrain Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no request from me right now. I'll look into this section of doc myself but this will have to be my tomorrow!

@mrgrain mrgrain self-requested a review July 3, 2023 16:45
@mrgrain mrgrain dismissed their stale review July 3, 2023 16:46

This doesn't work

@mrgrain mrgrain self-assigned this Jul 3, 2023
@ysuzuki19
Copy link
Contributor Author

note:

My Environment: Ubuntu 22.04.2 LTS x86_64

The build command exists in following

run: |-
docker buildx build \
--builder ${{ steps.buildx.outputs.name }} \
--platform linux/amd64,linux/arm64 \
--target superchain \
--pull \
--build-arg BUILD_TIMESTAMP="${{ steps.build-time.outputs.value }}" \
--build-arg COMMIT_ID='${{ github.sha }}' \
--build-arg NODE_MAJOR_VERSION=${{ matrix.node }} \
-f superchain/Dockerfile \
.

@ysuzuki19
Copy link
Contributor Author

Sorry I forgotten option --target.

Pushed it.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Jul 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 4, 2023

Merging (with squash)...

@mergify mergify bot merged commit 1b7c40c into aws:main Jul 4, 2023
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants