-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(superchain): maven version, docs: CONTRIBUTING.md #4162
Conversation
CONTRIBUTING.md
Outdated
$ IMAGE=superchain | ||
$ docker build -t ${IMAGE} ./superchain | ||
$ docker buildx build -t $IMAGE -f superchain/Dockerfile . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the old instructions here? Assuming they still work?
Open to offering both as alternative options though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the idea, but old instruction isn't working.
Because path of some COPY
instruction now no longer match (ref).
Do you still want to keep the old one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No that's fine then! Thanks for letting me know!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your response, but I just want to make sure I understand correctly.
Does that mean I can leave the code as it is now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, no request from me right now. I'll look into this section of doc myself but this will have to be my tomorrow!
note: My Environment: The build command exists in following jsii/.github/workflows/docker-images.yml Lines 134 to 145 in 877cdf8
|
Sorry I forgotten option Pushed it. |
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
This PR resolves Issue #4080 and bumps version of the maven from
3.9.2
to3.9.3
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.