Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(assembler): handle unknown types without crashing #501

Merged
merged 1 commit into from
May 7, 2019
Merged

fix(assembler): handle unknown types without crashing #501

merged 1 commit into from
May 7, 2019

Commits on May 7, 2019

  1. fix(assembler): handle unknown types without crashing 

    After failing compilation we proceed with jsii analysis, to give as much
information as possible in one go.

However, some compilation failures lead to a lack of information that
make the jsii analyzer crash, which ultimately leads jsii to fail with
no more information than:

    Error: TypeError: Cannot read property 'getJsDocTags' of undefined

Fix this in two ways:

- First, detect the situation where this occurs and produce a more
  useful error message.
- Guard against this happening in general by catching exceptions
  during type analysis and still printing the compilation errors.
    Rico Huijbers committed May 7, 2019
    Configuration menu
    Copy the full SHA
    4e31cd8 View commit details
    Browse the repository at this point in the history