Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dotnet): [JsiiOptional] attribute on properties that are optionals + Roslyn Analyzer #717
feat(dotnet): [JsiiOptional] attribute on properties that are optionals + Roslyn Analyzer #717
Changes from 8 commits
ca14ad2
c56fb4d
d09fd3e
57a65d7
529d285
f01fb1d
d2898aa
41971ca
5d606f8
2628400
0a65587
60145aa
21ac89f
d0b524e
129f966
08585f5
1aa2786
fd9e467
15ec285
e7b73b1
03b82f5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be copied to
dist
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based this file on the jsii-dotnet-runtime's one. It does not have a dist directory?
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.