fix(python): correctly handle interface declarations on returned objects #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the returned type had a known base type, the interfaces tagged on the object reference tag. This addresses this problem.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
suggested changes
Nov 13, 2019
- implement the test for #976 in Java and .NET (PASSED) - port `canLeverageIndirectInterfacePolymorphsm` to python (PASSED)
eladb
approved these changes
Nov 13, 2019
|
@RomainMuller I tool the liberty of implementing this test in .NET and Java, just in case, and also noticed that a related test is missing from python, so I added it (all passed). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
5 tasks
|
using 'Resource' object has no attribute ... error still exists. |
|
@dxunix I had to update all of the Python dependencies in my virtual env before the issue was resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the returned type had a known base type, the interfaces tagged on the object
reference tag. This addresses this problem.
Fixes #976
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.