Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpuCFSQuota support to kubeletConfiguration #3300

Closed
lucass4 opened this issue Jan 27, 2023 · 3 comments
Closed

Add cpuCFSQuota support to kubeletConfiguration #3300

lucass4 opened this issue Jan 27, 2023 · 3 comments
Labels
feature New feature or request good-first-issue Good for newcomers

Comments

@lucass4
Copy link
Contributor

lucass4 commented Jan 27, 2023

Tell us about your request

Adds cpuCFSQuota support into kubeletConfiguration

apiVersion: karpenter.sh/v1alpha5
kind: Provisioner
metadata:
  name: default
spec:
  ...
  kubeletConfiguration:
    cpuCFSQuota: true | false

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

I want to be able to disable CPU CFS quota enforcement for containers that specify CPU limits.

Are you currently working around this issue?

Currently, I'm solving it with the user data script.
Ref: https://aws.amazon.com/premiumsupport/knowledge-center/eks-worker-nodes-image-cache/ But I dislike having to maintain that file. It has caused problems.

Additional Context

If this one is approved, I would like to work on it.

Attachments

No response

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@lucass4 lucass4 added the feature New feature or request label Jan 27, 2023
@lucass4 lucass4 changed the title Add cpu-cfs-quota support to kubeletConfiguration Add cpuCFSQuota support to kubeletConfiguration Jan 27, 2023
@jonathan-innis jonathan-innis added the good-first-issue Good for newcomers label Jan 30, 2023
@lucass4
Copy link
Contributor Author

lucass4 commented Jan 30, 2023

@jonathan-innis I would like to work on this one.

@jonathan-innis
Copy link
Contributor

@lucass4 Can you provide your use-case for wanting to add this to the .spec.kubeletConfiguration?

@jonathan-innis
Copy link
Contributor

Closing since #187 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good-first-issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants